New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kyaml readwriter inconsistencies when wrapping resources #4235
Conversation
@Goodwine: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Goodwine! |
Hi @Goodwine. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
Please make sure your github username is set on your git commits! |
Ok I think I had wrong my email address in the CLA form thingy, maybe it's good now? |
I signed it |
I'll file a ticket because the CLA still appears as unmarked even after updating my data to my work email address |
|
OK I think I got it, I had private email addresses set, and I also didn't have my email configured in my account 😭 hopefully it works this time? |
/ok-to-test |
/assign @KnVerey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes and the detailed description of the problem in the attached issue! I agree with these changes, and the test coverage looks good. Would you mind moving the test cases to kyaml/kio/byteio_readwriter_test.go
and adjusting them to not involve the framework (maybe not Results either, up to you), since the coverage is really of kio wrapping behavior?
68af636
to
ba4d83f
Compare
I moved over the tests removing references to |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Goodwine, KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4234